Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding log for number of flows #194

Merged
merged 7 commits into from
Aug 16, 2024
Merged

Adding log for number of flows #194

merged 7 commits into from
Aug 16, 2024

Conversation

Alopalao
Copy link

Closes #192
Closes #104

Summary

Added log for number of flows and force option
Added condition for empty list of flows for events.

Local Tests

Created EVCs to see the logging

End-to-End Tests

N/A

@Alopalao Alopalao requested a review from a team as a code owner August 14, 2024 19:31
viniarck
viniarck requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise it's almost there.

Asked a minor change, and there's validation issue too.

Plus, changelog hasn't been updated either.

main.py Outdated Show resolved Hide resolved
main.py Show resolved Hide resolved
main.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
@viniarck viniarck self-requested a review August 15, 2024 16:36
viniarck
viniarck approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving it pre-approved.

@Alopalao before merging check out the dpid value validation though, once that's addressed go ahead and merge it.

main.py Show resolved Hide resolved
viniarck
viniarck reviewed Aug 15, 2024
View reviewed changes
main.py Outdated Show resolved Hide resolved
@Alopalao @viniarck
Update main.py
b601fc6 
Co-authored-by: Vinicius Arcanjo <[email protected]>
@viniarck viniarck self-requested a review August 15, 2024 18:11
viniarck
viniarck approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

img

Let's ship it @Alopalao, feel free to merge it.

@Alopalao Alopalao merged commit 17ccb73 into master Aug 16, 2024
1 check passed
@Alopalao Alopalao deleted the log_flows branch August 16, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniarck viniarck viniarck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Alopalao @viniarck